Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.0.0-rc.1 #2106

Merged
merged 12 commits into from
Feb 13, 2024
Merged

Release 5.0.0-rc.1 #2106

merged 12 commits into from
Feb 13, 2024

Conversation

SkymanOne
Copy link
Contributor

Added

  • Custom signature topic in Events - #2031
  • [Linter] non_fallible_api lint - #2004
  • [Linter] Publish the linting crates on crates.io - #2060
  • [E2E] Added create_call_builder for testing existing contracts - #2075
  • call_v2 cross-contract calls with additional limit parameters - #2077

Changed

  • Mapping: Reflect all possible failure cases in comments ‒ #2079
  • [E2E] Rename .call to .call_builder ‒ #2078
  • Improve syntax for ink! e2e runtime_only attribute argument - #2083
  • [E2E] Remove additional_contracts parameter #2098
  • [E2E] change node url backend config - #2101

Fixed

  • Fix the StorageVec type by excluding the len_cached field from its type info - #2052
  • Fix panic in approve_for in the ERC-721 example - #2092
  • ERC-721: transfer_token_from now ensures the token owner is correct - #2093

smiasojed
smiasojed approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@smiasojed smiasojed left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests failed:
error: the lock file /__w/ink/ink/Cargo.lock needs to be updated but --locked was passed to prevent this

@smiasojed smiasojed self-requested a review February 8, 2024 14:33
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ae81655) 53.67% compared to head (c53aef5) 53.63%.
Report is 1 commits behind head on master.

❗ Current head c53aef5 differs from pull request most recent head 85b59e4. Consider uploading reports for the commit 85b59e4 to get more accurate results

Files Patch % Lines
crates/e2e/src/backend_calls.rs 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2106      +/-   ##
==========================================
- Coverage   53.67%   53.63%   -0.04%     
==========================================
  Files         223      224       +1     
  Lines        7041     7046       +5     
  Branches     3117     3118       +1     
==========================================
  Hits         3779     3779              
- Misses       3262     3267       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with cargo-contract and comparing them to ink! master:

Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
call-builder-return-value 9.237 9.237 0 0 ➖
call-runtime 2.061 2.061 0 0 ➖
combined-extension 2.137 2.12 -0.017 -0.795508 📉
conditional-compilation 1.49 1.49 0 0 ➖
contract-storage 7.568 7.568 0 0 ➖
contract-terminate 1.329 1.329 0 0 ➖
contract-transfer 1.689 1.689 0 0 ➖
cross-contract-calls 5.835 5.835 0 0 ➖
cross-contract-calls/other-contract 1.583 1.583 0 0 ➖
custom-allocator 7.775 7.775 0 0 ➖
custom-environment 2.146 2.146 0 0 ➖
dns 7.318 7.318 0 0 ➖
e2e-call-runtime 1.296 1.296 0 0 ➖
e2e-runtime-only-backend 1.881 1.881 0 0 ➖
erc1155 14.308 14.308 0 0 ➖
erc20 6.918 6.918 0 0 ➖
erc721 10.007 10.007 0 0 ➖
events 5.258 5.258 0 0 ➖
flipper 1.639 1.639 0 0 ➖
incrementer 1.504 1.504 0 0 ➖
lang-err-integration-tests/call-builder-delegate 2.638 2.638 0 0 ➖
lang-err-integration-tests/call-builder 5.354 5.354 0 0 ➖
lang-err-integration-tests/constructors-return-value 1.985 1.985 0 0 ➖
lang-err-integration-tests/contract-ref 4.753 4.753 0 0 ➖
lang-err-integration-tests/integration-flipper 1.815 1.815 0 0 ➖
lazyvec-integration-test 4.616 4.616 0 0 ➖
mapping-integration-tests 7.999 7.999 0 0 ➖
mother 12.741 12.741 0 0 ➖
multi-contract-caller 6.313 6.313 0 0 ➖
multi-contract-caller/accumulator 1.378 1.378 0 0 ➖
multi-contract-caller/adder 1.912 1.912 0 0 ➖
multi-contract-caller/subber 1.932 1.932 0 0 ➖
multisig 21.821 21.821 0 0 ➖
payment-channel 5.659 5.659 0 0 ➖
psp22-extension 7.071 7.071 0 0 ➖
rand-extension 2.965 2.965 0 0 ➖
sr25519-verification 1.142 1.142 0 0 ➖
static-buffer 1.654 1.654 0 0 ➖
trait-dyn-cross-contract-calls 2.887 2.887 0 0 ➖
trait-dyn-cross-contract-calls/contracts/incrementer 1.545 1.545 0 0 ➖
trait-erc20 7.294 7.294 0 0 ➖
trait-flipper 1.49 1.49 0 0 ➖
trait-incrementer 1.614 1.614 0 0 ➖
upgradeable-contracts/delegator 3.151 3.151 0 0 ➖
upgradeable-contracts/delegator/delegatee 1.609 1.609 0 0 ➖
upgradeable-contracts/set-code-hash-migration 1.743 1.743 0 0 ➖
upgradeable-contracts/set-code-hash-migration/migration 1.45 1.45 0 0 ➖
upgradeable-contracts/set-code-hash-migration/updated-incrementer 1.897 1.897 0 0 ➖
upgradeable-contracts/set-code-hash 1.743 1.743 0 0 ➖
upgradeable-contracts/set-code-hash/updated-incrementer 1.721 1.721 0 0 ➖
wildcard-selector 2.846 2.846 0 0 ➖

Link to the run | Last update: Tue Feb 13 16:07:58 CET 2024

ascjones
ascjones reviewed Feb 8, 2024
View reviewed changes
Cargo.lock Outdated
Comment on lines 1019 to 1020
"ink_env 5.0.0-rc",
"ink_metadata 5.0.0-rc",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should first release these two packages, then release a new contract-transcode, then update to that version. Also will need to release and update contract-build at the same time, though that has no ink deps itself.

We should probably add that to the release process.

ascjones
ascjones reviewed Feb 9, 2024
View reviewed changes
RELEASES_CHECKLIST.md Outdated Show resolved Hide resolved
smiasojed
smiasojed reviewed Feb 13, 2024
View reviewed changes
integration-tests/e2e-runtime-only-backend/lib.rs
@@ -121,7 +121,7 @@ pub mod flipper {

// when
let call_data = vec![
Value::from_bytes(&contract.account_id),
Value::unnamed_variant("Id", [Value::from_bytes(contract.account_id)]),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may have sense to understand why and when it has changed.
I also noticed that the drink client returns metadata in version V14. Shouldn't it be V15?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the issue that we should resolve before the final release. For now, I'm just gonna push the release gracefully.

@SkymanOne SkymanOne merged commit 6c94c09 into master Feb 13, 2024
23 checks passed
@SkymanOne SkymanOne deleted the gn/5.0.0-rc.1 branch February 13, 2024 17:59
@SkymanOne SkymanOne added the Release Release PR or issue label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smiasojed smiasojed smiasojed approved these changes

@ascjones ascjones ascjones approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

Assignees
No one assigned
Labels
Release Release PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SkymanOne @codecov-commenter @ascjones @smiasojed